-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a release pipeline ⛏ #78
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
labels
Jun 13, 2019
vdemeester
force-pushed
the
release-pipeline
branch
from
June 13, 2019 14:58
1ffcb32
to
ee766f4
Compare
chmouel
reviewed
Jun 13, 2019
This will need to be run manually for the first(s) releases, but it sets pieces in place and help the dogfooding effort for Tekton Pipelines. It reuses golang tasks from the tektoncd/catalog *and* adds a `goreleaser` Task (using goreleaser). The pipeline runs the lint, then build the command and run the unit tests. It finaly cross build the binary for all targeted architecture and system and publish a draft release. Although this should be considered still a work in progress, it is still usable and will be run to make the v0.1.0 release of tektoncd/cli. Signed-off-by: Vincent Demeester <[email protected]>
Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
release-pipeline
branch
from
June 13, 2019 16:12
5dc93ab
to
a93607d
Compare
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This will need to be run manually for the first(s) releases, but it
sets pieces in place and help the dogfooding effort for Tekton
Pipelines.
It reuses golang tasks from the tektoncd/catalog and adds a
goreleaser
Task (using goreleaser).The pipeline runs the lint, then build the command and run the unit
tests. It finaly cross build the binary for all targeted architecture
and system and publish a draft release.
Although this should be considered still a work in progress, it is
still usable and will be run to make the v0.1.0 release of
tektoncd/cli.
/cc @sthaha @chmouel
This is slightly blocked by #77 (although both can be merged asynchronously)
Signed-off-by: Vincent Demeester [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.